Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side cache related naming changes #3758

Merged
merged 6 commits into from
Mar 10, 2024
Merged

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Mar 6, 2024

Changes:

  1. ClientSideCache and CommandLongHashing are good enough names on their own. But, IMO, these should have similar naming pattern; e.g. (Cache, Hash) or (Caching, Hashing). I opted for earlier option ATM.
    CommandLongHashing is renamed to CommandLongHasher.
  2. Expanded the names of GuavaCSC (GuavaClientSideCache) and CaffeineCSC (CaffeineClientSideCache).

Note for reviewers: Check #3757 to see how client-side cache support currently looks and to find other changes to suggest.

@chayim chayim requested a review from tishun March 7, 2024 07:18
@sazzad16 sazzad16 changed the title Some client side cache related naming changes Client-side cache related naming changes Mar 7, 2024
@sazzad16 sazzad16 requested a review from a team March 7, 2024 07:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.22%. Comparing base (c02e5be) to head (4b82cae).

❗ Current head 4b82cae differs from pull request most recent head e5a7659. Consider uploading reports for the commit e5a7659 to get more accurate results

Files Patch % Lines
.../redis/clients/jedis/csc/GuavaClientSideCache.java 54.54% 4 Missing and 1 partial ⚠️
...dis/clients/jedis/csc/CaffeineClientSideCache.java 71.42% 1 Missing and 1 partial ⚠️
.../java/redis/clients/jedis/util/JedisURIHelper.java 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.2.0    #3758      +/-   ##
============================================
+ Coverage     75.21%   75.22%   +0.01%     
- Complexity     5024     5028       +4     
============================================
  Files           309      309              
  Lines         15400    15399       -1     
  Branches       1171     1171              
============================================
+ Hits          11583    11584       +1     
- Misses         3297     3299       +2     
+ Partials        520      516       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit 1651b26 into redis:5.2.0 Mar 10, 2024
3 checks passed
@sazzad16 sazzad16 deleted the csc-namings branch March 10, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants