Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich the information returned by toString() of Connection #3745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jjz921024
Copy link

Currently, the information returned by tostring() of connection is very poor. we can refer the info format of netty channel to represent a connection

https://github.com/netty/netty/blob/3c65eae052b7f460e054e6ce765cfba7f433ea32/transport/src/main/java/io/netty/channel/AbstractChannel.java#L382-L419

@sazzad16
Copy link
Collaborator

Note: Due to unique id, existing usages like aConnection.toString(otherConnection.toString()) will fail.

@sazzad16 sazzad16 added discussion needed breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. labels Feb 28, 2024
@sazzad16 sazzad16 added this to the 5.2.0 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 81.92%. Comparing base (2d42338) to head (952da8d).

Files Patch % Lines
src/main/java/redis/clients/jedis/Connection.java 0.00% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3745      +/-   ##
============================================
- Coverage     82.13%   81.92%   -0.21%     
+ Complexity     6016     6013       -3     
============================================
  Files           301      301              
  Lines         15273    15304      +31     
  Branches       1190     1193       +3     
============================================
- Hits          12544    12538       -6     
- Misses         2162     2196      +34     
- Partials        567      570       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. discussion needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants