Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute Redis commands using Netty #3606

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Execute Redis commands using Netty #3606

wants to merge 11 commits into from

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Nov 6, 2023 •
edited

No description provided.

@sazzad16 sazzad16 requested a review from chayim November 6, 2023 07:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023 •
edited by codecov bot

Codecov Report

Attention: Patch coverage is 61.42132% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 75.19%. Comparing base (c1cc657) to head (800ff4d).
Report is 61 commits behind head on master.

❗ Current head 800ff4d differs from pull request most recent head 15c4cfc. Consider uploading reports for the commit 15c4cfc to get more accurate results

Files Patch % Lines
.../redis/clients/jedis/asyncio/CommandArguments.java 22.64% 30 Missing and 11 partials ⚠️
...clients/jedis/asyncio/CommandArgumentsHandler.java 47.61% 21 Missing and 1 partial ⚠️
.../clients/jedis/asyncio/CommandResponseHandler.java 84.61% 1 Missing and 7 partials ⚠️
...n/java/redis/clients/jedis/asyncio/Connection.java 85.71% 3 Missing and 1 partial ⚠️
...is/clients/jedis/asyncio/replies/CommandReply.java 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3606      +/-   ##
============================================
- Coverage     75.37%   75.19%   -0.19%     
- Complexity     4892     4930      +38     
============================================
  Files           297      305       +8     
  Lines         14962    15159     +197     
  Branches       1130     1152      +22     
============================================
+ Hits          11278    11399     +121     
- Misses         3189     3244      +55     
- Partials        495      516      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chayim
chayim previously approved these changes Nov 7, 2023
View reviewed changes
@chayim chayim self-requested a review November 7, 2023 12:58
@sazzad16 sazzad16 marked this pull request as draft November 7, 2023 12:59
@sazzad16
Grab Redis server reply (status and bulk)
880ce0a 
and print
@sazzad16
Merge branch 'master' into netty-01
4d8e135
@sazzad16
Credit
004846e
@sazzad16
Return replies (async)
06feae3 
Issues:
    In test, last GET operation is not populating reply.
    But if we add a PING, not only we get the reply of GET but also PING.
@sazzad16
Comment flaky
989eb05
@sazzad16
Reformat and todo comments
15c4cfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim Awaiting requested review from chayim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
experimental will not fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sazzad16 @codecov-commenter @chayim