Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure a Sentinel Connection when initialising the Sentinel pool #1943

Merged
merged 5 commits into from Nov 26, 2019
Merged

Configure a Sentinel Connection when initialising the Sentinel pool #1943

merged 5 commits into from Nov 26, 2019

Commits on Jan 28, 2019

  1. This commit attempts to resolve #1487 and #1636. 

    Added a constructor to JedisSentinelPool to configure a Sentinel
connection with respective timeout settings and a password.
    Karl Tinawi authored and Karl Tinawi committed Jan 28, 2019
    Copy the full SHA
    dd46bdd View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Initial code review. 

    - Removed the default password variable
- Always initialise Jedis with password (null password is ignored)
- Move sentinal parameters after client parameters
    Karl Tinawi committed Jan 29, 2019
    Copy the full SHA
    080c413 View commit details
    Browse the repository at this point in the history

  2. Code review. 

    - Added constructor to allow 'sentinelClientName'.
- Use auth() and clientSetName() when creating Jedis to connect to sentinel
- Removed newly added constructors from Jedis and BinaryJedis
    Karl Tinawi committed Jan 29, 2019
    Copy the full SHA
    a24025a View commit details
    Browse the repository at this point in the history

  3. Code review. 

    - Removed constructor the defaults sentinelClientName to 'null'.
- Resolved 'tab' indentation
- Moved all sentinel instance variables after 'master' variables.
    Karl Tinawi committed Jan 29, 2019
    Copy the full SHA
    c6abed6 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Format code.

    @sazzad16
    sazzad16 committed Nov 26, 2019
    Copy the full SHA
    7ffb1cd View commit details
    Browse the repository at this point in the history