Some code cleanups #1888
Closed
Some code cleanups #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gkorland
commented
Nov 5, 2018
gkorland
commented
- diamonds operator
- missing final
- index of with '' when possible
1. diamonds operator 2. missing final 3. index of with '' when possible
sazzad16
requested changes
Nov 6, 2018
There was a problem hiding this comment.
Personally, I prefer nested enums to be declared static for the sake of readability. Let's see what @marcosnils says.
|
@sazzad16 but there is no need every nested enum is static |
# Conflicts: # src/main/java/redis/clients/jedis/util/JedisByteHashMap.java
|
@sazzad16 any more comments but the |
sazzad16
requested changes
Nov 25, 2019
| @@ -20,7 +20,7 @@ | |||
| public Pool() { | |||
| } | |||
|
|
|||
| public Pool(final GenericObjectPoolConfig poolConfig, PooledObjectFactory<T> factory) { | |||
| public Pool(final GenericObjectPoolConfig<T> poolConfig, PooledObjectFactory<T> factory) { | |||
There was a problem hiding this comment.
Won't this create backward compatibility issue?
| @@ -33,7 +33,7 @@ public boolean isClosed() { | |||
| return this.internalPool.isClosed(); | |||
| } | |||
|
|
|||
| public void initPool(final GenericObjectPoolConfig poolConfig, PooledObjectFactory<T> factory) { | |||
| public void initPool(final GenericObjectPoolConfig<T> poolConfig, PooledObjectFactory<T> factory) { | |||
|
@gkorland Except |
|
I guess we can close this PR since we just merged #2100 |
|
I'll submit a new PR |
|
okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.