Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes passing in family parameter in URL in node 18 #1673

Merged
merged 2 commits into from Nov 2, 2022
Merged

Fixes passing in family parameter in URL in node 18 #1673

merged 2 commits into from Nov 2, 2022

Commits on Nov 2, 2022

  1. Fixes passing in family parameter in URL in node 18 

    Node 18 stopped coercing the type for its options (specifically the ip family option) and instead throws an error. So if you pass in `?family=6` in your Redis URL, it would fail because when it does the DNS lookup passing in the string `'6'`, node would throw an error.
    @ksmithut
    ksmithut committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6cb541c View commit details
    Browse the repository at this point in the history

  2. fixes formatting

    @ksmithut
    ksmithut committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    5b8038e View commit details
    Browse the repository at this point in the history