Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reconnect] fixes #1138 #1139

Merged
merged 2 commits into from May 30, 2020
Merged

[reconnect] fixes #1138 #1139

merged 2 commits into from May 30, 2020

Conversation

alexandre-abrioux
Copy link
Contributor

Hi,

This PR has been opened following the issue #1138.
It might also fix #1007 (not tested).

Thank you for your time!

: options.password,
auth: options.username
? [options.username, options.password]
: options.password,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a change made by prettier during husky pre-commit hook

@luin luin merged commit 6fad73b into redis:master May 30, 2020
@luin
Copy link
Collaborator

luin commented May 30, 2020

Awesome! Good catch!

@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto reconnect doesn't work under certains circumstances
3 participants