Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _readyCheck INFO parser's handling of colon characters #1127

Merged

Commits on May 8, 2020

  1. Fix _readyCheck INFO parser's handling of colon characters

    This commit fixes an issue which would occur when encountering INFO
    response field values containing the colon character.
    
    Because the parser logic splits entire lines upon colon character
    delimiters and took only the first component as the field name, and
    second component as the field value, any line containing multiple
    colons would ultimately lead to an incorrectly truncated field value.
    
    For example:
      "config_file:Y:\\redis\\redis.conf"
    
    Would be split into:
      ["config_file", "Y", "\\redis\\redis.conf"]
    
    Leading to a field name of "config_file" and an incorrect field value
    of "Y".
    
    The resolution is simply to handle additional field value components as
    needed, joining them together appropriately.
    Rua-Yuki committed May 8, 2020
    Copy the full SHA
    4aaa391 View commit details
    Browse the repository at this point in the history