Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry import - fix trace error #1542

Closed
wants to merge 1 commit into from

Conversation

gonzalochief
Copy link

@gonzalochief gonzalochief commented Oct 16, 2020

I fixed the import that was causing an error on clean (newly created) development environments.
The original code was importing a package that does not exists anymore as it was merged into the Otel package.
The code is working on my development machine (Linux). The fix should go to the master repo and branch so build actions do not fail on builds that pull the source directly from GitHub.

@vmihailenco
Copy link
Collaborator

This PR is similar to #1541 . The proper fix is described at #1534

As you should know go-redis uses Go modules to manage dependencies. You must use Go modules or use some other mechanism to pin dependencies to some version. It is not optional.

This PR does not provide any reliable way to build go-redis and therefore does not fix anything. go-redis will be "broken" again as soon as there is a change in dev version of any other go-redis dependency. And it is completely fine - it is your workflow that is broken / unsupported.

At the same time this PR makes impossible to update go-redis for majority of users that properly use Go modules. Because after this change master branch requires unreleased and unstable OpenTelemetry version which is not meant for production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants