Bump to v1.10.0 #367
Merged
Bump to v1.10.0 #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we update |
|
Changelog.md is antiquated. I would prefer we use GH releases. |
PikachuEXE
approved these changes
Sep 11, 2023
|
Tagging is up to you (for the first time at least? I have never used the publish workflow) |
|
Release workflow failed: https://github.com/redis-store/redis-store/actions/runs/6142539725/job/16664447332 Manually releasing from my machine. |
|
redis-store v1.10.0 now out: https://rubygems.org/gems/redis-store/versions/1.10.0 |
|
This is due to https://github.com/redis-store/redis-store/blob/v1.10.0/.github/workflows/publish.yml#L18
|
|
Did you happen to forget to create the release changelog entry for v1.10.0? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off the back of #366, we will need to bump the version number before we can do another release.