Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encoding as false for gulp.src to treat content as binary. #209

Merged
merged 1 commit into from May 3, 2024

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented May 3, 2024

All jars passing through gulp.src are corrupted. I noticed that pre-release bulds were failing for vscode-quarkus & vscode-microprofile. When I examined the actual logs, I was seeing :

!ENTRY org.eclipse.jdt.ls.core 4 0 2024-05-02 16:27:12.411
!MESSAGE Failed to load extension bundles
!STACK 1
org.eclipse.core.runtime.CoreException: Load bundle list
    at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.loadBundles(BundleUtils.java:173)
...
...
Contains: Cannot extract bundle symbolicName or version /home/rgrunber/.vscode/extensions/redhat.vscode-microprofile-0.12.2024041608/jars/org.eclipse.lsp4mp.jdt.core.jar
java.util.zip.ZipException: zip END header not found
    at java.base/java.util.zip.ZipFile$Source.findEND(Unknown Source)
    at java.base/java.util.zip.ZipFile$Source.initCEN(Unknown Source)
    at java.base/java.util.zip.ZipFile$Source.<init>(Unknown Source)
    at java.base/java.util.zip.ZipFile$Source.get(Unknown Source)
    at java.base/java.util.zip.ZipFile$CleanableResource.<init>(Unknown Source)
    at java.base/java.util.zip.ZipFile.<init>(Unknown Source)
    at java.base/java.util.zip.ZipFile.<init>(Unknown Source)
    at java.base/java.util.jar.JarFile.<init>(Unknown Source)
    at java.base/java.util.jar.JarFile.<init>(Unknown Source)
    at java.base/java.util.jar.JarFile.<init>(Unknown Source)
    at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.getBundleInfo(BundleUtils.java:328)
    at org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.loadBundles(BundleUtils.java:120)
    at org.eclipse.jdt.ls.core.internal.handlers.InitHandler.handleInitializationOptions(InitHandler.java:114)
    at org.eclipse.jdt.ls.core.internal.handlers.BaseInitHandler.initialize(BaseInitHandler.java:64)
    at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.initialize(JDTLanguageServer.java:284)

When I examined the jars, I noticed they appear to be corrupted. At first I thought it was the build process but then realized it was Gulp 5 (#196). Tracked down gulpjs/gulp#2797 and the workaround seems to work.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added the build label May 3, 2024
@rgrunber rgrunber added this to the 0.12.0 milestone May 3, 2024
@rgrunber rgrunber merged commit e72d002 into redhat-developer:master May 3, 2024
3 checks passed
@rgrunber rgrunber deleted the fix-gulp5-corruption branch May 3, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant