Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation rules #694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix indentation rules #694

wants to merge 1 commit into from

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Oct 29, 2018 •
edited

... by copying the ones used for js/ts.

Fixes #692

@fbricon fbricon changed the title Fix indentation rules by copying the [ones used for js/ts](https://github.com/Microsoft/vscode/blob/41ddd41b71ea2bd5c6e49125beeb3e951f3d9c7c/extensions/typescript-language-features/src/features/languageConfiguration.ts#L17-L18). Fix indentation rules Oct 29, 2018
@fbricon fbricon requested a review from snjeza October 29, 2018 22:56
snjeza
snjeza reviewed Oct 30, 2018
View reviewed changes
Copy link
Contributor

@snjeza snjeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can reproduce the issue #692.

@fbricon
Copy link
Collaborator Author

fbricon commented Oct 30, 2018

mmm that sucks. Seems like this works with vscode insiders but not the last official release. @snjeza can you double check that please?

@fbricon
Copy link
Collaborator Author

fbricon commented Oct 30, 2018

Looks like the same issue exists in typescript in the last vscode release. Works with insiders (I'm using the same patterns). So I'd say, we ship it anyway. It'll be available to users on regular vscode in early November.

@snjeza
Copy link
Contributor

snjeza commented Oct 30, 2018

I can also reproduce the issue with code-insiders-1.29.0. I have tested on Windows and Linux.

Version: 1.29.0-insider (system setup)
Commit: 2b06dd1ca31e407abed24f65e1804ae86180401d
Date: 2018-10-30T11:12:35.070Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

The issue can't be reproduced if we exclude the Java extension.

@fbricon fbricon mentioned this pull request Oct 30, 2018
Closed
@fbricon
Copy link
Collaborator Author

fbricon commented Oct 30, 2018

@snjeza FYI I opened microsoft/vscode#62198 upstream

@fbricon fbricon mentioned this pull request Nov 6, 2018
Open
@fbricon
Fix indentation rules
c215aee 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snjeza snjeza snjeza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbricon @snjeza