Avoid sending an "empty" (lacking project data) startup event. #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rgrunber
commented
May 16, 2024
rgrunber
commented
- When the language server import takes too long (>60s), an "empty" startup event is sent to at least capture some data. This can result in duplicate events when a project import finally completes, or a (now) useless event if something goes wrong.
- Avoid sending such events as there are better ways to determine if the language server encountered an error
- When the language server import takes too long (>60s), an "empty" startup event is sent to at least capture some data. This can result in duplicate events when a project import finally completes, or a (now) useless event if something goes wrong. - Avoid sending such events as there are better ways to determine if the language server encountered an error Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
remove-empty-startup
branch
from
e0c00a3
to
63d2905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.