Move Type Hierarchy implementation to LSP #2376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2022
CsCherrYY
force-pushed
the
cs-typehierarchy-impl
branch
from
a6de45d
to
bff041f
Compare
CsCherrYY
force-pushed
the
cs-typehierarchy-impl
branch
from
bff041f
to
c393ba1
Compare
|
Can this along with the change on the language server be revived now that we've updated to the 3.17 spec ? |
I'm looking at this. The UX change (some UI limitation) of this PR is mentioned in #2376 (comment) |
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-typehierarchy-impl
branch
from
c393ba1
to
819c31a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires eclipse-jdtls/eclipse.jdt.ls#2033
The change is able to review/merge, but we will get several BREAKING changes, so feel free to discuss we can now continue the process or wait for further changes.
Pros:
Cons:
The type hierarchy in LSP only supports supertype hierarchy and subtype hierarchy, no class hierarchy. We should still hold custom implementations about the class hierarchy view.
Since "Show Type Hierarchy" is contributed from language client/vscode itself, we have no way to control its behavior, so the default view of "Show Type Hierarchy" would be the subtype hierarchy view. We added a new entry "Show Class hierarchy" to open the class hierarchy view by default.
As for those types have no children, the star will always show there. This is also the limitation of current call hierarchy view.
