Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor symbol does not work with @Builder annotation #2411

Open
conscious-puppet opened this issue Apr 14, 2022 · 9 comments
Open

Refactor symbol does not work with @Builder annotation #2411

conscious-puppet opened this issue Apr 14, 2022 · 9 comments
Assignees

Comments

@conscious-puppet
Copy link

Refactor symbol does not work after annotating the class with @Builder from Lombok.

Environment
  • Operating System: Windows
  • JDK version: 11
  • Visual Studio Code version: 1.66
  • Java extension version: 1.5.0
Steps To Reproduce
  1. Annotate the class with @Builder
  2. Use refactor symbol to rename an instance variable.
Current Result

Rename/Refactor is not reflected.

Expected Result

Should rename the instance variable.

@jdneo
Copy link
Collaborator

jdneo commented Apr 15, 2022

Seems refactoring feature will break when lombok is enabled, another one: #1596

fyi @testforstephen

@snjeza
Copy link
Contributor

snjeza commented Apr 19, 2022

@abshekh @jdneo @testforstephen you may want to take a look at #2417 (comment)
A related issue: projectlombok/lombok#3134

@conscious-puppet
Copy link
Author

@snjeza i tried with Lombok v1.18.24. The issue still persists for me. After removing @Builder annotation renaming works, but with it renaming does not work. :(

@snjeza
Copy link
Contributor

snjeza commented Apr 22, 2022

@abshekh See eclipse-jdtls/eclipse.jdt.ls#2062 (comment)

@conscious-puppet
Copy link
Author

@snjeza please have a look at this recording.

ipl-dashboard-1650679426019

@snjeza
Copy link
Contributor

snjeza commented Apr 23, 2022

please have a look at this recording.

I can reproduce it. Thanks.

@snjeza
Copy link
Contributor

snjeza commented Apr 23, 2022

This is an upstream lombok bug - projectlombok/lombok#3181

@abshekh you can try https://github.com/snjeza/vscode-test/raw/master/lombok-1.18.25.jar

@conscious-puppet
Copy link
Author

@snjeza thanks. refactor works with the jar you provided :)

@snjeza
Copy link
Contributor

snjeza commented Apr 24, 2022

@abshekh reopening as projectlombok/lombok#3181 hasn't been fixed yet.
https://github.com/snjeza/vscode-test/raw/master/lombok-1.18.25.jar is a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants