Refactor symbol doesn't work with @Builder annotation

[snjeza]

Steps to reproduce:

• open the following file in Eclipse or VS Code

import lombok.Builder;
@Builder
public class Input {
	private String id;
}

• select the id field
• try to rename it
  You can also try to find its references.

The original issue: redhat-developer/vscode-java#2411

A potential patch:

diff --git a/src/core/lombok/eclipse/handlers/HandleBuilder.java b/src/core/lombok/eclipse/handlers/HandleBuilder.java
index a2dd5057..6c6e50a2 100755
--- a/src/core/lombok/eclipse/handlers/HandleBuilder.java
+++ b/src/core/lombok/eclipse/handlers/HandleBuilder.java
@@ -983,7 +983,7 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {
                                }
                                
                                if (field == null) {
-                                       FieldDeclaration fd = new FieldDeclaration(bfd.builderFieldName, 0, 0);
+                                       FieldDeclaration fd = new FieldDeclaration(bfd.builderFieldName.clone(), 0, 0);
                                        fd.bits |= Eclipse.ECLIPSE_DO_NOT_TOUCH_FLAG;
                                        fd.modifiers = ClassFileConstants.AccPrivate;
                                        fd.type = copyType(bfd.type);
@@ -991,7 +991,7 @@ public class HandleBuilder extends EclipseAnnotationHandler<Builder> {
                                        field = injectFieldAndMarkGenerated(job.builderType, fd);
                                }
                                if (setFlag == null && bfd.nameOfSetFlag != null) {
-                                       FieldDeclaration fd = new FieldDeclaration(bfd.nameOfSetFlag, 0, 0);
+                                       FieldDeclaration fd = new FieldDeclaration(bfd.nameOfSetFlag.clone(), 0, 0);
                                        fd.bits |= Eclipse.ECLIPSE_DO_NOT_TOUCH_FLAG;
                                        fd.modifiers = ClassFileConstants.AccPrivate;
                                        fd.type = TypeReference.baseTypeReference(TypeIds.T_boolean, 0);

• Version: 1.8.24
• Platform: all

[Rawi01]

In eclipse the rename action shows a red error message in the lower left but still works because it fallbacks to in file editing. The fix works, do you know why cloning the array helps?

[snjeza]

do you know why cloning the array helps?

@Rawi01 JDT uses the reference equality when comparing a field name.
You may want to take a look at https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/SelectionEngine.java#L1760