Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If deleting a resource gives a 404 we should be fine #58

Merged
merged 2 commits into from Oct 28, 2022
Merged

If deleting a resource gives a 404 we should be fine #58

merged 2 commits into from Oct 28, 2022

Conversation

juandspy
Copy link
Collaborator

@juandspy juandspy commented Oct 28, 2022 •
edited

Fix some errors appearing in all the tests, f.e in this one:

Error: Error waiting for example instance (FztVctEr3pp1_zWNGjG-M) to be deleted: The requested resource or service could not be found :: 404 Not Found :: mock-api:8000/api/kafkas_mgmt/v1/kafkas/FztVctEr3pp1_zWNGjG-M :: GET

Tests are still not passing probably because of the mock server.

@juandspy juandspy marked this pull request as ready for review October 28, 2022 10:00
jackdelahunt
jackdelahunt approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@jackdelahunt jackdelahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just need to fix linter

@juandspy
Copy link
Collaborator Author

LGTM +1 just need to fix linter

fixed, I had to find a workaround

@jackdelahunt jackdelahunt merged commit c72e657 into redhat-developer:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackdelahunt jackdelahunt jackdelahunt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juandspy @jackdelahunt