Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use client#patch instead of #createOrReplace (#561) #580

Merged
merged 1 commit into from
Mar 14, 2023
Merged

use client#patch instead of #createOrReplace (#561) #580

merged 1 commit into from
Mar 14, 2023

Conversation

adietish
Copy link
Collaborator

fixes #561

@adietish adietish self-assigned this Mar 13, 2023
@adietish adietish force-pushed the issue-561 branch 3 times, most recently from c727083 to bb69266 Compare March 13, 2023 13:17
@adietish adietish requested a review from sbouchet March 13, 2023 13:31
@adietish adietish marked this pull request as ready for review March 13, 2023 14:36
@adietish adietish requested review from datho7561 and JessicaJHee and removed request for datho7561 March 13, 2023 14:36
JessicaJHee
JessicaJHee approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests on my end and the fix works as expected! Would just make sure that all the use cases covered by the deleted/modified test cases are still covered.

@adietish
use client#patch instead of #createOrReplace (redhat-developer#561)
efdbc8f 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
Copy link
Collaborator Author

rebased and pushed force.

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adietish adietish merged commit 67cb78f into redhat-developer:main Mar 14, 2023
@adietish adietish deleted the issue-561 branch March 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaJHee JessicaJHee JessicaJHee approved these changes

@sbouchet sbouchet Awaiting requested review from sbouchet

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushing pod with spec errors if it already exists on cluster
2 participants
@adietish @JessicaJHee