Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Chains to use the SharedSecret resource #534

Merged
merged 2 commits into from Jul 28, 2022
Merged

Allow Chains to use the SharedSecret resource #534

merged 2 commits into from Jul 28, 2022

Conversation

lcarva
Copy link
Member

@lcarva lcarva commented Jul 27, 2022

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from chmouel and Michkov July 27, 2022 16:07
@lcarva lcarva marked this pull request as ready for review July 27, 2022 16:39
@openshift-ci openshift-ci bot requested review from ksprinkl and sbose78 July 27, 2022 16:39
gabemontero
gabemontero reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment and question (though if my assumptions are incorrect perhaps a req for change)

README.md Show resolved Hide resolved
components/build/tekton-chains/tekton-chains-controller-shared-secret.yaml Show resolved Hide resolved
@lcarva lcarva force-pushed the chains-shared-secrets branch 2 times, most recently from 256695d to f421e94 Compare July 27, 2022 17:45
@gabemontero
Copy link
Contributor

/lgtm

let's let @Michkov chime in when he is back on the clock tomorrow and if he is good he can apply the approve label

@openshift-ci openshift-ci bot added the lgtm label Jul 27, 2022
@lcarva lcarva changed the title Allow Chains to use the SharedSecret resource [WIP - DO NOT MERGE] Allow Chains to use the SharedSecret resource Jul 27, 2022
@lcarva lcarva changed the title [WIP - DO NOT MERGE] Allow Chains to use the SharedSecret resource WIP - DO NOT MERGE - Allow Chains to use the SharedSecret resource Jul 27, 2022
@lcarva
Copy link
Member Author

lcarva commented Jul 27, 2022

Flagging this as WIP (I can't figure how to move it back to a draft).

The e2e tests caught a valid issue. If the underlying Secret does not exist, the path is a directory instead of a file. This causes the k8schain library to crash.

@openshift-ci openshift-ci bot removed the lgtm label Jul 27, 2022
lcarva
lcarva commented Jul 28, 2022
View reviewed changes
README.md Show resolved Hide resolved
@lcarva lcarva changed the title WIP - DO NOT MERGE - Allow Chains to use the SharedSecret resource Allow Chains to use the SharedSecret resource Jul 28, 2022
@lcarva
Remove post-bootstrap doc for Chains
3bebb92 
The signing secret is created automatically by the PostSync Job
named tekton-chains-signing-secret.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva
Allow Chains to use the SharedSecret resource
6821e0a 
https://issues.redhat.com/browse/HACBS-922

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@simonbaird
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, simonbaird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9450cc8 into redhat-appstudio:main Jul 28, 2022
@lcarva lcarva deleted the chains-shared-secrets branch July 28, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero gabemontero left review comments

@simonbaird simonbaird simonbaird approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@Michkov Michkov Awaiting requested review from Michkov

@ksprinkl ksprinkl Awaiting requested review from ksprinkl

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@simonbaird simonbaird

@gabemontero gabemontero

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
4 participants
@lcarva @gabemontero @simonbaird @openshift-merge-robot