Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run action with NodeJS 16 #26

Closed
wants to merge 1 commit into from
Closed

Run action with NodeJS 16 #26

wants to merge 1 commit into from

Conversation

der-eismann
Copy link
Contributor

Description

As mentioned in #24 (comment) the action itself still runs on NodeJS 12, while it is built/tested with NodeJS 16. Let's push everything to 16, just like other actions did.
Unfortunately this is seen as a breaking change because it is incompatible with GitHub Enterprise Server <= 3.3.

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

  • Changed action so it runs on node16
  • Changed package.json so it requests node16

@github-actions github-actions bot added the CRDA Scan Pending CRDA scan waiting for approval label Jun 14, 2022
@der-eismann der-eismann deleted the nodejs-16 branch June 15, 2022 11:50
@ssbarnea
Copy link

Can we revive this, Github already deprecated all actions using node 12 and there are warnings on all builds using actions based on node 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRDA Scan Pending CRDA scan waiting for approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants