Replaced isfunction & ismethod with isroutine #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pretty much returns exactly the same as before, but with the benefit of including C functions/methods. You can read more about that here: https://stackoverflow.com/a/17019998/6901146
KTAtkinson
requested changes
Jul 15, 2022
Co-authored-by: Katie Atkinson <kaitlin@atkinson.mn>
|
@KTAtkinson so... I can't re-run the workflow since I am a "First-time contributor". Would you please do me the honors to approve the run? |
KTAtkinson
approved these changes
Jul 18, 2022
|
What do you think? Shall I adapt the test cases? (: |
KTAtkinson
requested changes
Jul 18, 2022
|
@KTAtkinson I have replaced |
KTAtkinson
approved these changes
Jul 19, 2022
|
Awesome! @KTAtkinson you need anything more from my end for this PR? (: Btw I'd really appreciate an "Open Sorcerer" trophy on my Reddit profile |
|
💇♀️ |
|
Nothing else needed from your end, we are working to get a critical feature out now, so I won't be able to release this for a bit. |
KTAtkinson
approved these changes
Jul 28, 2022
|
💇♀️ |
KTAtkinson
approved these changes
Jan 4, 2023
|
hi @KTAtkinson it looks like @aba-ca-xi isn't available (anymore?). Could you please assign another reviewer? |
|
@maeivysea maybe? |
|
@KTAtkinson when merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pretty much returns exactly the same as before, but with the benefit of including C functions/methods. You can read more about that here:
https://stackoverflow.com/a/17019998/6901146