php-cs-fixer: utilize multiple processors #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
May 11, 2021
.github/workflows/code-style.yml
Outdated
| @@ -39,7 +39,7 @@ jobs: | |||
|
|
|||
| - name: Fix code style | |||
| if: env.writable == 1 | |||
| run: vendor/bin/php-cs-fixer fix --diff | |||
| run: vendor/bin/php-cs-fixer list-files --config=.php-cs-fixer.dist.php | xargs -n 150 -P 3 vendor/bin/php-cs-fixer fix --diff --config=.php-cs-fixer.dist.php | |||
There was a problem hiding this comment.
Ich habe den eindruck..
- parallelisierung beschleunigt den schritt hier von ca 20-22 auf 12-14 sekunden
- der cs-fixer hat vor dem PR hier einen cache aufgebaut und diesen als seiteneffekt in zeile 53 genutzt - jetzt scheinbar nicht mehr
- cs-fixer parallel laufen zu lassen und anschließend die ausgabe durch cs2pr pipen, scheint aktuell nicht möglich
There was a problem hiding this comment.
- der cs-fixer hat vor dem PR hier einen cache aufgebaut und diesen als seiteneffekt in zeile 53 genutzt - jetzt scheinbar nicht mehr
Irgendwo hatte ich es schon mal angemerkt, dieser Zweit-Check ist aus meiner Sicht eigentlich überflüssig.
Denn wenn hier etwas gefixt und commitet wird, wird anschließend ja sowieso die ganze Action neu gestartet.
Wir brauchen den dry-mode mit cs2pr aber trotzdem für Fork/Dependabot-PRs. Aber er muss nicht ablaufen, wenn schon hier der fix-Schritt ablief.
staabm
changed the title
staabm
changed the title
|
Ready to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utilize multi core capabilities. Using 3 processes at a time, because github action VMs have 2 cpus, but cs-fixer is also doing some IO and therefore its likely processes are blocked for IO.
In CI php-cs-fixer cannot benefit from the cs-fixer-cache, therefore running things in parallel results in a great perf boost.
Refs PHP-CS-Fixer/PHP-CS-Fixer#5390