Various fixes to initial GitHub Actions #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
| @@ -69,7 +73,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go: ["1.17", "1.18"] | |||
| go: ["1.18", "1.19"] | |||
| make-target: ["verify-deps", "verify-generated", "verify-latest-csv", "verify-operator-bundle", "verify-latest-deploy-yaml"] | |||
There was a problem hiding this comment.
Do we need this make-target matrix any more?
There was a problem hiding this comment.
Removed, and also fixed some of the jobs that had wrong targets 😂
...that merged too early ;) Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
jarrpa
force-pushed
the
merge-jarrpa-dev
branch
from
b3cabdf
to
16297af
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...that merged too early in #1814 ;)
The golangci-lint changes were tricky, but basically it comes down to some weirdness in running it using Go 1.19 versus Go 1.18 for golangci-lint v1.49.0. Specifically, it was this change in 1.48.0 that was causing us so much pain: golangci/golangci-lint#3002
In addition, the original configuration listed both
go-versionandgo-version-fileconfiguration options, andgo-versionwas being taken as the preferred one. Unfortunately, our code still fails against Go 1.19 for some reason, so for the time being we're forcing the Action to target Go 1.18 across the job's config matrix. I kept the matrix at["1.18","1.19"]just so we don't have to change it later when we do start moving to 1.19.Signed-off-by: Jose A. Rivera jarrpa@redhat.com