Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Take .editorconfig into account #6272

Merged
merged 7 commits into from May 6, 2021
Merged

[TASK] Take .editorconfig into account #6272

merged 7 commits into from May 6, 2021

Conversation

sabbelasichon
Copy link
Contributor

Resolves: #6215

@sabbelasichon
Copy link
Contributor Author

The minimum-stability and prefer-stable is still there because the dev-master of idiosyncratic-code/editorconfig-php contains important bugfixes from my side. Stable release will be published soon.

@sabbelasichon
Copy link
Contributor Author

Still need some refactoring and hardening of the API

TomasVotruba
TomasVotruba reviewed May 1, 2021
View reviewed changes
phpstan.neon Outdated Show resolved Hide resolved
@TomasVotruba
Copy link
Member

Looking at this feature, there is lot of files all around /src. It would be better to have it in one directory together so it's easier to work with related files.

  • the /src code should be in packages/FileFormatter
  • the /tests code should be in packages-tests/FileFormatter

@sabbelasichon
Copy link
Contributor Author

Ready for review.

TomasVotruba
TomasVotruba reviewed May 2, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@TomasVotruba
Copy link
Member

Ready to merge?

@sabbelasichon
Copy link
Contributor Author

Not yet. I am doing the sniff part first today. This seems reasonable.

@TomasVotruba
Copy link
Member

All right 👍

I've added "ready-to-merge" label so you can mark PRs when ready.

@sabbelasichon
Copy link
Contributor Author

@TomasVotruba Ready to merge. I have streamlined the API and do the sniffing in the FileFormatter based on the original content.

I cannot add a label here. Am i missing something?

@TomasVotruba
Copy link
Member

Check https://github.com/rectorphp/rector/invitations and try again. Should be fine :)

@TomasVotruba TomasVotruba merged commit 16d5930 into rectorphp:main May 6, 2021
@TomasVotruba
Copy link
Member

Thank you 👍 👍

@sabbelasichon sabbelasichon mentioned this pull request May 6, 2021
Merged
This was referenced May 21, 2021
Open
Open
@renovate renovate bot mentioned this pull request Jun 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

@lulco lulco lulco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take editorconfig into account for non php files.
3 participants
@sabbelasichon @TomasVotruba @lulco