Rename phpunit.xml to phpunit.xml.dist #5785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's optional naming, I would like to keep it simple instead of disting everything that can. What do you need override for? |
|
Had to make changes while #5784 was in a preliminary state... I mean the |
|
If there is no reason to add, there is no need to add extra complexity. |
TomasVotruba
added a commit
that referenced
this pull request
Mar 31, 2024
rectorphp/rector-src@d869306 [TypeDeclaration] Handle in inner function on ReturnTypeFromStrictTernaryRector (#5785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my knowledge, it is an established practice to name the PHPUnit configuration file
phpunit.xml.dist, so that a per-developer configuration can override it inphpunit.xml.