[Downgrade PHP 7.3] Trailing commas in function calls

[quisse]

#4168

[quisse]

After some digging I can conclude that this is not possible using php-parser because php-parser isn't aware of the trailing comma AFAIK.
Any help would be appreciated.

[TomasVotruba]

I came to similar conslussion when PHP 7.3 was released.

Maybe php-cs-fixer is better for this job

[quisse]

So is including php-cs-fixer as a dependency an option? It would be nice if rectorphp makes downgrading every php version possible.

[quisse]

Triggering regeneration removes the trailing commas. The only side effect I'm aware of is that when having a method call inline in a string in a method call, the curly brackets are doubled.

    public function refactor(Node $node): ?Node
    {
        if($node->args){
            $node->setAttribute(AttributeKey::ORIGINAL_NODE,null);
        }
        return $node;
    }

Makes

        $this->setOnClick("[Zip ID: {$modelid}]  {$e->getMessage($modelId,)}");

results in

        $this->setOnClick("[Zip ID: {$modelid}]  {{$e->getMessage($modelId)}}");

A possible workaround could be

    public function refactor(Node $node): ?Node
    {
        if($node->args){
            if(! $node->getAttribute(AttributeKey::PARENT_NODE) instanceof Node\Scalar\Encapsed){
                $node->setAttribute(AttributeKey::ORIGINAL_NODE,null);
            }
        }
        return $node;
    }

But the trailing comma isn't removed then.

[TomasVotruba]

Removing original node usually lead to reprint without format. Then it depends on default printer setting.

What could work is do is hack around BetterStandardPrinter and remove comma there.

[quisse]

With this one I am waiting for nikic/PHP-Parser#732.
That issue causes that "[Zip ID: {$modelid}] {$e->getMessage($modelId)}" is rewritten as "[Zip ID: {$modelid}] {{$e->getMessage($modelId)}}"

[quisse]

@TomasVotruba updating nikic/phpparser doesn't seem sufficient, do I need to wait for phpstan to include the latest phpparser or am I missing something?

[TomasVotruba]

I'll look into this

[TomasVotruba]

These 2 last details are ok. Do not change the code meaning and solves the comma.

Merged in: #4796

Thank you 👍