[PHPUnit 9.0] Add TestListenerToHooksRector

[TomasVotruba]

Closes #1266

Migration path for sebastianbergmann/phpunit#3389

How to apply?

composer require rector/rector --dev
vendor/bin/rector process tests --level phpunit90

Showcase

 <?php

 namespace App\Tests;

-use PHPUnit\Framework\TestListener;
-
-final class BeforeListHook implements TestListener
+final class BeforeListHook implements \PHPUnit\Runner\BeforeTestHook, \PHPUnit\Runner\AfterTestHook
 {
-    public function addError(Test $test, \Throwable $t, float $time): void
-    {
-    }
-
-    public function addWarning(Test $test, Warning $e, float $time): void
-    {
-    }
-
-    public function addFailure(Test $test, AssertionFailedError $e, float $time): void
-    {
-    }
-
-    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void
-    {
-    }
-
-    public function addRiskyTest(Test $test, \Throwable $t, float $time): void
-    {
-    }
-
-    public function addSkippedTest(Test $test, \Throwable $t, float $time): void
-    {
-    }
-
-    public function startTestSuite(TestSuite $suite): void
-    {
-    }
-
-    public function endTestSuite(TestSuite $suite): void
-    {
-    }

-    public function startTest(Test $test): void
+    public function executeBeforeTest(Test $test): void
     {
         echo 'start test!';
     }

-    public function endTest(Test $test, float $time): void
+    public function executeAfterTest(Test $test, float $time): void
     {
         echo $time;
     }
 }

[joesaunderson]

@TomasVotruba in the hook, how are you getting a Test type? The new hooks pass a string?

[TomasVotruba]

Not sure what you mean. Code sample?

[joesaunderson]

Rector change:

public function executeBeforeTest(Test $test): void
     {
         echo 'start test!';
     }

PHPUnit Interface:

interface BeforeTestHook extends TestHook
{
    public function executeBeforeTest(string $test): void;
}

[TomasVotruba]

What's expected change?

[joesaunderson]

That’s the point, I don’t think it’s a straightforward change that can be done automatically.

But changing as above will not work (string will be passed instead of Test type)

[TomasVotruba]

So what is expected behavior for such a listener? No change?

It's deprecated and will be removed, so there must be some upgrade path.

[joesaunderson]

I’m not sure on the upgrade path, see here for changes sebastianbergmann/phpunit#3388

But I do know, that the new interfaces no longer pass the Test type around.

[joesaunderson]

@sebastianbergmann what would the upgrade path be for this change?

Am I right in thinking the changes above do not correctly implement the interfaces?