Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing AnnotationToAttribute in framework-extra-61.php #140

Merged
merged 1 commit into from Apr 7, 2022
Merged

Add missing AnnotationToAttribute in framework-extra-61.php #140

merged 1 commit into from Apr 7, 2022

Conversation

guillaumesmo
Copy link
Contributor

No description provided.

@TomasVotruba
Copy link
Member

Hi, thanks for the update.

Could you share link to PR in Symfony where this was changed to attribute or something?

@guillaumesmo
Copy link
Contributor Author

Could you share link to PR in Symfony where this was changed to attribute or something?

Sure, but it's already as a comment in the file: sensiolabs/SensioFrameworkExtraBundle#707

@TomasVotruba
Copy link
Member

Thanks for sharing 👍

I see: https://github.com/sensiolabs/SensioFrameworkExtraBundle/pull/707/files#diff-271cb32a64f16eded511bd1e25c605bc33229f43b46e8a1284cec39b583a0eb6R21

Let's ship it :)

@TomasVotruba TomasVotruba merged commit 90eecd6 into rectorphp:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guillaumesmo @TomasVotruba