Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector #5691

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector #5691

wants to merge 3 commits into from

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Mar 5, 2024 •
edited

No description provided.

@TomasVotruba TomasVotruba changed the title tv dyna rule [CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector Mar 5, 2024
@TomasVotruba TomasVotruba marked this pull request as draft March 5, 2024 10:39
@staabm
Copy link
Contributor

staabm commented Mar 5, 2024 •
edited

just a drive-by thing which came to my mind: I think the rule should be skipped when a class has magic __get or __set-methods because declaring a real property will prevent php from calling the magic methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TomasVotruba @staabm @actions-user