Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle $reflectionProperty->getDefaultValueExpression() return null #3446

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 3, 2023

Ref rector-doctrine test error https://github.com/rectorphp/rector-doctrine/actions/runs/4321563757/jobs/7542937994#step:5:19


 [ERROR] Could not process                                                      
         "/home/runner/work/rector-doctrine/rector-doctrine/src/NodeAnalyzer/Set
         terClassMethodAnalyzer.php" file, due to:                              
         "System error:                                                         
         "PHPStan\BetterReflection\Reflection\Adapter\ReflectionProperty::getDef
         aultValueExpression(): Return value must be of type                    
         PhpParser\Node\Expr, null returned"                                    
         Run Rector with "--debug" option and post the report here: 
https://github.com/rectorphp/rector/issues/new
". On line:

On PR rectorphp/rector-doctrine#154

@samsonasik samsonasik enabled auto-merge (squash) March 3, 2023 09:55
@samsonasik samsonasik merged commit 658e48f into main Mar 3, 2023
@samsonasik samsonasik deleted the hanlde-default-value-expr-null branch March 3, 2023 10:01
@TomasVotruba
Copy link
Member

Thank you 👍

Github Actions were down yesterday evening so I missed this.

samsonasik added a commit that referenced this pull request May 8, 2023
…3446)

* Handle $reflectionProperty->getDefaultValueExpression() return null

* fix

* fix

* pull from BetterReflection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants