Skip not natively typed property in AddParamTypeFromPropertyTypeRector #3421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
AddParamTypeFromPropertyTypeRector
the property type inference also used the PHPDoc types. This PR fixes this.I also the same (regression) test fixture for the AddMethodCallBasedStrictParamTypeRector.
I'm wondering if we should replace
NodeTypeResolver->getType()
withgetNativeType()
on more places in the TypeDeclaration namespace.