Allow class vs function names on imports #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-fix-fully-qualified-name-skipper
branch
2 times, most recently
from
b1f18fa
to
37fe246
Compare
TomasVotruba
force-pushed
the
tv-fix-fully-qualified-name-skipper
branch
from
246c340
to
7365457
Compare
samsonasik
pushed a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to block import of class name
View, that was same as function nameview:https://github.com/TomasVotruba/tomasvotruba.com/pull/1366/files#diff-d7dc7f08f1bba97551472cbda3a39db9a18e93ab06e499d18f6895ecc3df25f7L11
The class can be easily imported 馃憤