[StaticReflection] Fix unintended behavior in PHP 8.1 and later #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 |
samsonasik
requested changes
Feb 6, 2023
|
Oh, already merged, I will checked on laminas-servicemanager-migration that rename interface instead of class and check if there is no regression |
|
@zeriyoshi I verified in laminas-servicemanager-migration for rename interface and it seems working ok, thank you 👍 ➜ laminas-servicemanager-migration git:(1.13.x) ✗ vendor/bin/phpunit
PHPUnit 9.6.3 by Sebastian Bergmann and contributors.
................... 19 / 19 (100%)
Time: 00:03.495, Memory: 166.50 MB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 changes the behavior of passing null to built-in functions, so that the current Rector does not throw an error when processing non-existent classes and does not properly perform code conversion.
https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.core.null-not-nullable-internal
Applying this fix will at least correct the above problem with Reflection.
But maybe this is an issue that should be addressed on the PHPStan side. I suggest a workaround on the Rector side for now.