[Php81] Skip ReadOnlyPropertyRector on read only class

[samsonasik]

Based on tweet https://twitter.com/_Codito_/status/1605889532553052161

[samsonasik]

/cc @Wirone

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[Wirone]

Currently rule only checks if readonly should be added to promoted properties, but that PR to Laminas had different scenario: promoted properties already had readonly.

There should be also fixture for scenario where class' promoted properties have readonly and class doesn't have it: when readonly is added on class level, properties' readonlys should be removed.

[samsonasik]

That already covered at ReadonlyClassRector, see this transformation

rector-src/rules-tests/Php82/Rector/Class_/ReadOnlyClassRector/Fixture/only_readonly_property2.php.inc

Lines 5 to 20 in 7f8f9f8

	final class OnlyReadonlyProperty2
	{
	public function __construct(private readonly string $property)
	{
	}
	}
	?>
	-----
	<?php
	namespace Rector\Tests\Php82\Rector\Class_\ReadOnlyClassRector\Fixture;
	final readonly class OnlyReadonlyProperty2
	{
	public function __construct(private string $property)

the multi rules back to add readonly again on ReadonlyPropertyRector because found a readonly property, which was doesn't check the class already readonly so flip flop was happen ,this PR fix it :)

[Wirone]

Aaahhh, ok, so it was removed and added again, hence no diff 😅 Thanks for clarification!