Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodingStyle] Add NullifyUnionNullableRector #3231

Merged
merged 28 commits into from Dec 21, 2022
Merged

[CodingStyle] Add NullifyUnionNullableRector #3231

merged 28 commits into from Dec 21, 2022

Conversation

samsonasik
Copy link
Member

To convert already typed null|stdClass to ?stdClass

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik force-pushed the add-nullify-union-nullable-rector branch from 7031d20 to dfe0b08 Compare December 21, 2022 09:35
@samsonasik samsonasik changed the title [Php80] Add NullifyUnionNullableRector [CodingStyle] Add NullifyUnionNullableRector Dec 21, 2022
@samsonasik
Copy link
Member Author

I make it optional by unregister from coding-style config set.

@samsonasik
Copy link
Member Author

I register NullifyUnionNullableRector to MissingInSetCommand e0fa88c

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit f132077 into main Dec 21, 2022
@TomasVotruba TomasVotruba deleted the add-nullify-union-nullable-rector branch December 21, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user