Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parallel] Fix missing process RemovedAndAddedFilesProcessor->run() on parallel process on WorkerRunner #3218

Merged
merged 9 commits into from Dec 19, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 19, 2022

jtojnar and others added 3 commits December 19, 2022 15:45
Otherwise `RemovedAndAddedFilesCollector` will print something like the following and that would need to be baked into `expected-output.diff`:

    [NOTE] File "/home/user/Projects/rector-src/e2e/removed-and-added-files-collector/test" will be added
Currently failing when parallel running is enabled.
@samsonasik
Copy link
Member Author

it works 🎉

@samsonasik
Copy link
Member Author

It may need an integration to run in ApplicationFileProcessor vs duplicate usage on PhpFileProcessor

@samsonasik
Copy link
Member Author

samsonasik commented Dec 19, 2022

When it apply on PhpFileProcessor, when parallel disabled back, now got 2 output on disable paralell:

+! [NOTE] File "./removed-and-added-files-collector/test" will be added
+
+ ! [NOTE] File "./removed-and-added-files-collector/test" will be added
+
+ ! [NOTE] 1 files were added
+
+

so definatelly the integration usage is needed.

@samsonasik
Copy link
Member Author

Ok, so the parallel work on WorkerRunner, so it needs to run under WorkerRunner 2431a59




[OK] Rector is done!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this [OK] Rector is done! printed message should actually not exists with run with parallel along with:

$this->removedAndAddedFilesProcessor->run($configuration)

as it is running with --dry-run, but probably need in separate PRs for improvement 👍 :)

@samsonasik samsonasik changed the title [Parallel] Fix missing process RemovedAndAddedFilesProcessor->run() on parallel process on PhpFileProcessor [Parallel] Fix missing process RemovedAndAddedFilesProcessor->run() on parallel process on WorkerRunner Dec 19, 2022
@samsonasik
Copy link
Member Author

Finally 🎉 All checks have passed 🎉 🎉 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

While I am at it, I applied use FileProcessorInterface so all implementation of FileProcessorInterface will be applied in parallel proces 🎉 b0d9731

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Member

Thank you 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants