[Core] Performance improvement: Remove unnecessary re-call FileFactory::createFileInfosFromPaths()

[samsonasik]

There is already initialization early in ApplicationFileProcessor::run()

$fileInfos = $this->fileFactory->createFileInfosFromPaths($configuration->getPaths(), $configuration);

rector-src/src/Application/ApplicationFileProcessor.php

Lines 63 to 65 in f2e4da5

	public function run(Configuration $configuration, InputInterface $input): array
	{
	$fileInfos = $this->fileFactory->createFileInfosFromPaths($configuration->getPaths(), $configuration);

so, internal call:

$filePaths = $this->createFileInfosFromPaths($paths, $configuration);

inside createFromPaths() method no longer needed, as it can just consume existing defined initialization $fileInfos string array data.

It only happen on non-parallel configuration.

so:

✔️ Remove double Loop (only once at initialization already)
✔️ Remove double run clear cache
✔️ Remove double method call internally.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

Nice catch: 😉