Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Skip standalone @return false or true on RemoveUselessReturnTagRector #3202

Merged
merged 5 commits into from Dec 15, 2022

Conversation

samsonasik
Copy link
Member

The following code should be skipped:

final class SkipReturnStandaloneTrueFalseByReturnBool
{
    /**
     * @return true
     */
    function someTrue(): bool
    {
        return true;
    }

    /**
     * @return false
     */
    function someFalse(): bool
    {
        return false;
    }
}

Ref https://phpstan.org/r/6fbad07c-4b5e-4d89-8970-03df898abc6e

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik merged commit 0d6234b into main Dec 15, 2022
@samsonasik samsonasik deleted the skip-standalone-return-false-true branch December 15, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants