Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Skip append array data on RemoveJustPropertyFetchRector #3201

Merged
merged 2 commits into from Dec 14, 2022

Conversation

samsonasik
Copy link
Member

The following code should be skipped:

final class SkipAppendArrayData
{
    private $default = ['some data'];

    public function run()
    {
        $where = $this->default;
        $where[] = 'some append data';
    }
}

ref https://3v4l.org/UlZB6

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 🙏

@TomasVotruba TomasVotruba merged commit e71df1b into main Dec 14, 2022
@TomasVotruba TomasVotruba deleted the skip-append-array-data branch December 14, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants