Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php82] Handle parent already readonly on ReadOnlyClassRector #3199

Merged
merged 4 commits into from Dec 14, 2022
Merged

[Php82] Handle parent already readonly on ReadOnlyClassRector #3199

merged 4 commits into from Dec 14, 2022

Conversation

samsonasik
Copy link
Member

If parent class already readonly, child (current class analyzed) must be readonly too, ref https://3v4l.org/D9N7A

Fixes rectorphp/rector#7665

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @kevariable

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@kevariable
Copy link

Thank you for the great work @samsonasik

@TomasVotruba
Copy link
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit be3bdd0 into main Dec 14, 2022
@TomasVotruba TomasVotruba deleted the handle-readonly-parent-already-readonly branch December 14, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @kevariable @TomasVotruba