- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 383
[TypeDeclaration] Handle return self on TypedPropertyFromStrictGetterMethodReturnTypeRector on php 8.0 feature enabled #3088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nTypeRector # Failing Test for TypedPropertyFromStrictGetterMethodReturnTypeRector Based on https://getrector.org/demo/ee1243f2-fa5c-4460-a27d-31fb67439bbf
…MethodReturnTypeRector no php 8.0 feature enabled
It seems cause error on 2) Rector\Tests\DowngradePhp70\Rector\ClassMethod\DowngradeSelfTypeDeclarationRector\DowngradeSelfTypeDeclarationRectorTest::test with data set #1 ('/home/runner/work/rector-src/...hp.inc')
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
class Fixture
{
- /**
- * @return $this
- */
- public function getSelf()
+ public function getSelf(): self
{
return $this;
} The at least php version check possibly needed. |
@TomasVotruba the patch seems needs to be in both here and due to the mapper used in both:
|
@TomasVotruba I created PR to rector-downgrade-php that required for it: that need to be merged first before this. |
Build restarted |
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Let's merge and verify scoped build |
@TomasVotruba it works 🎉 |
Thank you 👏 |
Closes #3085