Fix StrContainsRector when strpos offset is set #3086
Merged
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Nov 22, 2022
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
approved these changes
Nov 22, 2022
staabm
reviewed
Nov 22, 2022
| @@ -82,6 +85,13 @@ public function refactor(Node $node): ?Node | |||
| return null; | |||
| } | |||
|
|
|||
| if (isset($funcCall->args[2])) { | |||
| if ($this->isName($funcCall->name, 'strpos') && $this->isPositiveInteger($funcCall->args[2]->value)) { | |||
There was a problem hiding this comment.
I guess the same is true for stripos?
There was a problem hiding this comment.
This rule only works with strpos y strstr
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://getrector.org/demo/e99068d4-3691-4653-ab58-24f20efa13bf
This is my first PR on this project. Thanks for your work!