[CodeQuality] Skip different value left and right on SimplifyEmptyArrayCheckRector #2998
+102
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Failing Test for SimplifyEmptyArrayCheckRector Based on https://getrector.org/demo/ad7024a9-7588-4c19-81bf-414fedb11ba0
samsonasik
commented
Oct 17, 2022
Comment on lines
+149
to
+152
| // skip same line that cause infinite loop | ||
| if ($rangeLine === 0) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Given the following code:
if ($node->expr instanceof FuncCall) {
return ! $node->expr->isFirstClassCallable() && $this->isName($node->expr, 'array_filter') && isset($node->expr->args[0]);
}it cause infinite loop during extracting && operator to each stmt and add new line after it, this handle it.
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2997 Fixes rectorphp/rector#7543