Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class-string typehint to MethodCallRename #2726

Merged
merged 3 commits into from Aug 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/Arguments/ValueObject/ArgumentAdder.php
Expand Up @@ -11,6 +11,7 @@
final class ArgumentAdder
{
/**
* @param class-string $class
* @param mixed|null $argumentDefaultValue
*/
public function __construct(
Expand Down
3 changes: 3 additions & 0 deletions rules/Arguments/ValueObject/RemoveMethodCallParam.php
Expand Up @@ -8,6 +8,9 @@

final class RemoveMethodCallParam
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $methodName,
Expand Down
Expand Up @@ -16,6 +16,7 @@ final class ReplaceArgumentDefaultValue implements ReplaceArgumentDefaultValueIn
public const ANY_VALUE_BEFORE = '*ANY_VALUE_BEFORE*';

/**
* @param class-string $class
* @param int<0, max> $position
*/
public function __construct(
Expand Down
Expand Up @@ -8,6 +8,9 @@

final class BinaryToVersionCompareCondition implements ConditionInterface
{
/**
* @param class-string $binaryClass
*/
public function __construct(
private readonly VersionCompareCondition $versionCompareCondition,
private readonly string $binaryClass,
Expand Down
3 changes: 3 additions & 0 deletions rules/Php80/ValueObject/ClassNameAndTagValueNode.php
Expand Up @@ -10,6 +10,9 @@

final class ClassNameAndTagValueNode
{
/**
* @param class-string $enumClass
*/
public function __construct(
private readonly string $enumClass,
private readonly ParamTagValueNode|ReturnTagValueNode|VarTagValueNode $tagValueNode
Expand Down
Expand Up @@ -10,6 +10,7 @@
final class ReplaceStringWithClassConstant
{
/**
* @param class-string $class
* @param class-string $classWithConstants
*/
public function __construct(
Expand Down
3 changes: 3 additions & 0 deletions rules/Removing/ValueObject/ArgumentRemover.php
Expand Up @@ -9,6 +9,9 @@

final class ArgumentRemover
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method,
Expand Down
3 changes: 3 additions & 0 deletions rules/Renaming/ValueObject/MethodCallRename.php
Expand Up @@ -10,6 +10,9 @@

final class MethodCallRename implements MethodCallRenameInterface
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $oldMethod,
Expand Down
3 changes: 3 additions & 0 deletions rules/Renaming/ValueObject/MethodCallRenameWithArrayKey.php
Expand Up @@ -10,6 +10,9 @@

final class MethodCallRenameWithArrayKey implements MethodCallRenameInterface
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $oldMethod,
Expand Down
4 changes: 4 additions & 0 deletions rules/Renaming/ValueObject/RenameClassAndConstFetch.php
Expand Up @@ -10,6 +10,10 @@

final class RenameClassAndConstFetch implements RenameClassConstFetchInterface
{
/**
* @param class-string $oldClass
* @param class-string $newClass
*/
public function __construct(
private readonly string $oldClass,
private readonly string $oldConstant,
Expand Down
3 changes: 3 additions & 0 deletions rules/Renaming/ValueObject/RenameClassConstFetch.php
Expand Up @@ -10,6 +10,9 @@

final class RenameClassConstFetch implements RenameClassConstFetchInterface
{
/**
* @param class-string $oldClass
*/
public function __construct(
private readonly string $oldClass,
private readonly string $oldConstant,
Expand Down
4 changes: 4 additions & 0 deletions rules/Renaming/ValueObject/RenameStaticMethod.php
Expand Up @@ -9,6 +9,10 @@

final class RenameStaticMethod
{
/**
* @param class-string $oldClass
* @param class-string $newClass
*/
public function __construct(
private readonly string $oldClass,
private readonly string $oldMethod,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/ArgumentFuncCallToMethodCall.php
Expand Up @@ -9,6 +9,9 @@

final class ArgumentFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInterface
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $function,
private readonly string $class,
Expand Down
2 changes: 1 addition & 1 deletion rules/Transform/ValueObject/ArrayFuncCallToMethodCall.php
Expand Up @@ -11,7 +11,7 @@ final class ArrayFuncCallToMethodCall implements ArgumentFuncCallToMethodCallInt
{
/**
* @param non-empty-string $function
* @param non-empty-string $class
* @param class-string $class
* @param non-empty-string $arrayMethod
* @param non-empty-string $nonArrayMethod
*/
Expand Down
2 changes: 2 additions & 0 deletions rules/Transform/ValueObject/AttributeKeyToClassConstFetch.php
Expand Up @@ -7,6 +7,8 @@
final class AttributeKeyToClassConstFetch
{
/**
* @param class-string $attributeClass
* @param class-string $constantClass
* @param array<string, string> $valuesToConstantsMap
*/
public function __construct(
Expand Down
4 changes: 4 additions & 0 deletions rules/Transform/ValueObject/DimFetchAssignToMethodCall.php
Expand Up @@ -9,6 +9,10 @@

final class DimFetchAssignToMethodCall
{
/**
* @param class-string $listClass
* @param class-string $itemClass
*/
public function __construct(
private readonly string $listClass,
private readonly string $itemClass,
Expand Down
4 changes: 4 additions & 0 deletions rules/Transform/ValueObject/MethodCallToStaticCall.php
Expand Up @@ -9,6 +9,10 @@

final class MethodCallToStaticCall
{
/**
* @param class-string $oldClass
* @param class-string $newClass
*/
public function __construct(
private readonly string $oldClass,
private readonly string $oldMethod,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/NewToStaticCall.php
Expand Up @@ -9,6 +9,9 @@

final class NewToStaticCall
{
/**
* @param class-string $staticCallClass
*/
public function __construct(
private readonly string $type,
private readonly string $staticCallClass,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/PropertyAssignToMethodCall.php
Expand Up @@ -9,6 +9,9 @@

final class PropertyAssignToMethodCall
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $oldPropertyName,
Expand Down
Expand Up @@ -9,6 +9,9 @@

final class ReplaceParentCallByPropertyCall
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/StaticCallToFuncCall.php
Expand Up @@ -9,6 +9,9 @@

final class StaticCallToFuncCall
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/StaticCallToMethodCall.php
Expand Up @@ -12,6 +12,9 @@

final class StaticCallToMethodCall
{
/**
* @param class-string $staticClass
*/
public function __construct(
private readonly string $staticClass,
private readonly string $staticMethod,
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/StaticCallToNew.php
Expand Up @@ -8,6 +8,9 @@

final class StaticCallToNew
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method
Expand Down
3 changes: 3 additions & 0 deletions rules/Transform/ValueObject/StringToClassConstant.php
Expand Up @@ -8,6 +8,9 @@

final class StringToClassConstant
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $string,
private readonly string $class,
Expand Down
Expand Up @@ -9,6 +9,9 @@

final class AddPropertyTypeDeclaration
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $propertyName,
Expand Down
Expand Up @@ -10,6 +10,9 @@

final class AddReturnTypeDeclaration
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method,
Expand Down
3 changes: 3 additions & 0 deletions rules/Visibility/ValueObject/ChangeConstantVisibility.php
Expand Up @@ -9,6 +9,9 @@

final class ChangeConstantVisibility
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $constant,
Expand Down
3 changes: 3 additions & 0 deletions rules/Visibility/ValueObject/ChangeMethodVisibility.php
Expand Up @@ -8,6 +8,9 @@

final class ChangeMethodVisibility
{
/**
* @param class-string $class
*/
public function __construct(
private readonly string $class,
private readonly string $method,
Expand Down