ExplicitMethodCallOverMagicGetSetRector fix

[MartinMystikJonas]

Fix for rectorphp/rector#7325

[TomasVotruba]

Thanks! Could you add the failing test fixture, so we have feature covered?

[MartinMystikJonas]

@TomasVotruba I can try

[MartinMystikJonas]

OK it seems fix would be more complicated than I thought. For objects with magic methods hasProperty always returns maybe so we cannot check for property existence

[MartinMystikJonas]

I see three options:

1. Use try/catch and skip rule if getProperty fails
2. Skip rule even for hasProperty()->maybe()
3. apply rule even for unknown properties by ignoring impossible check of types by

if (! $propertyType->isSuperTypeOf($returnType)->yes()) {
    continue;
}

because it is only place where it is used.

I would go for option 2 but I am not sure it is right way.

[TomasVotruba]

I would go for option 2 but I am not sure it is right way.

Seems the most valid way 👍

How the test perform with this solution?

[MartinMystikJonas]

Pushed option 2. Old tests passes and new test works with this.

[TomasVotruba]

LGTM 👍 Thank you