Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip RemoveAlwaysTrueIfConditionRector on property use by @var docblock #2717

Merged
merged 13 commits into from Jul 27, 2022
Merged

[DeadCode] Skip RemoveAlwaysTrueIfConditionRector on property use by @var docblock #2717

merged 13 commits into from Jul 27, 2022

Conversation

samsonasik
Copy link
Member

The @var usage in property is not reliable to check that PropertyFetch is based on the Property type, so it should be skipped.

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

I add failing test case for call outside object

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik merged commit 89bd84e into main Jul 27, 2022
@samsonasik samsonasik deleted the skip-by-var branch July 27, 2022 18:47
@samsonasik samsonasik mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba