[TypeDeclaration] Handle crash on intersection in Union type on AddMethodCallBasedStrictParamTypeRector

[samsonasik]

Given the following code:

abstract class SkipIntersectionInUnion
{
    public function prepareParameters(): array
    {
        $parameters =  array_merge($this->getRequestParameters(), [
            'request' => $this->getRequestName(),
        ]);

        $parameters = $this->removeEmptyValues($parameters);

        return array_map(static fn ($parameter) => 'test', $parameters);
    }

    private function removeEmptyValues($input): array
    {
        foreach ($input as &$value) {
            if (! is_array($value)) {
                continue;
            }

            $value = $this->removeEmptyValues($value);
        }

        return array_filter($input, static fn ($val) => true);
    }
}

it produce error:

There was 1 error:

1) Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\IntersectionTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Error: Object of class PhpParser\Node\IntersectionType could not be converted to string

Fixes rectorphp/rector#7311

[samsonasik]

Fixed 🎉 /cc @canvural

[canvural]

That was super fast. Thank you!

[TomasVotruba]

This looks pretty complex. Is there a way to make this fixture simpler to only contain the intersection type?

[samsonasik]

updated with reduce complexity dc54a42, that's the only code that reproduce the error

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

rebased.

[samsonasik]

rebased.

[TomasVotruba]

👍