[DeadCode] Add RemoveJustVariableAssignRector

config/set/early-return.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector;
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
 use Rector\EarlyReturn\Rector\Foreach_\ReturnAfterToEarlyOnBreakRector;
 use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
@@ -17,16 +18,19 @@
 use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;
 
 return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ChangeNestedForeachIfsToEarlyContinueRector::class);
-    $rectorConfig->rule(ChangeAndIfToEarlyReturnRector::class);
-    $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
-    $rectorConfig->rule(ChangeNestedIfsToEarlyReturnRector::class);
-    $rectorConfig->rule(RemoveAlwaysElseRector::class);
-    $rectorConfig->rule(ReturnBinaryAndToEarlyReturnRector::class);
-    $rectorConfig->rule(ChangeOrIfReturnToEarlyReturnRector::class);
-    $rectorConfig->rule(ChangeOrIfContinueToMultiContinueRector::class);
-    $rectorConfig->rule(ReturnAfterToEarlyOnBreakRector::class);
-    $rectorConfig->rule(PreparedValueToEarlyReturnRector::class);
-    $rectorConfig->rule(ReturnBinaryOrToEarlyReturnRector::class);
-    $rectorConfig->rule(ReturnEarlyIfVariableRector::class);
+    $rectorConfig->rules([
+        ChangeNestedForeachIfsToEarlyContinueRector::class,
+        ChangeAndIfToEarlyReturnRector::class,
+        ChangeIfElseValueAssignToEarlyReturnRector::class,
+        ChangeNestedIfsToEarlyReturnRector::class,
+        RemoveAlwaysElseRector::class,
+        ReturnBinaryAndToEarlyReturnRector::class,
+        ChangeOrIfReturnToEarlyReturnRector::class,
+        ChangeOrIfContinueToMultiContinueRector::class,
+        ReturnAfterToEarlyOnBreakRector::class,
+        PreparedValueToEarlyReturnRector::class,
+        ReturnBinaryOrToEarlyReturnRector::class,
+        ReturnEarlyIfVariableRector::class,
+        // RemoveJustVariableAssignRector::class,
+    ]);
 };

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_array_dim_fetch.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SkipArrayDimFetch
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $result = 100;
+
+        $this->temporaryValue[] = $result;
+    }
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_referenced_variable.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SkipReferencedVariable
+{
+    private $temporaryValue;
+
+    public function run(&$result)
+    {
+        $result = 100;
+
+        $this->temporaryValue = $result;
+    }
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_ternary_assigned.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SkipTernaryAssigned
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $result = 100 ? 10 : 5;
+
+        $this->temporaryValue = $result;
+    }
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/skip_used_later.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SkipUsedLater
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $result = 100;
+
+        $this->temporaryValue = $result;
+
+        if ($result === 100) {
+            return false;
+        }
+    }
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/Fixture/some_class.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SomeClass
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $result = 100;
+
+        $this->temporaryValue = $result;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector\Fixture;
+
+final class SomeClass
+{
+    private int $temporaryValue;
+
+    public function run()
+    {
+        $this->temporaryValue = 100;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/RemoveJustVariableAssignRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class RemoveJustVariableAssignRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustVariableAssignRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\StmtsAwareInterface\RemoveJustVariableAssignRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(RemoveJustVariableAssignRector::class);
+};

rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector.php

@@ -177,7 +177,7 @@ function (Node $node) use ($variableUsages, $propertyFetch): ?PropertyFetch {
                 $parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
                 if ($parentNode instanceof ClosureUse) {
                     // remove closure use which will be replaced by a property fetch
-                    $this->nodesToRemoveCollector->addNodeToRemove($parentNode);
+                    $this->removeNode($parentNode);
 
                     return null;
                 }