Add failing test fixture for AnnotationToAttributeRector

[javaDeveloperKid]

Failing Test for AnnotationToAttributeRector

Based on https://getrector.org/demo/4753f273-2649-4a87-bf0f-5ed01e1246e5

[javaDeveloperKid]

BTW. This https://github.com/rectorphp/rector-src/blob/main/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Doctrine/doctrine_join_table.php.inc test case is wrong in my opinion. First rector does not leave annotation for @JoinTable - it does what link in my description shows, second you cannot use both annotations and attributes at the time with doctrine (ofc one can write custom chain-like driver but this is not a case rector should consider).

[TomasVotruba]

I wonder how this file differs from https://github.com/rectorphp/rector-src/blob/main/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Doctrine/doctrine_join_table.php.inc
They seem have the same input example.

It would be better update that one instead adding a duplicate.

[TomasVotruba]

I thought JoinTable supports nested attributes, but it does not:

#[JoinTable(name: "user_groups")]
#[JoinColumn(name: "user_id", referencedColumnName: "id")]
#[InverseJoinColumn(name: "group_id", referencedColumnName: "id")]
private $groups;

Ref: https://www.doctrine-project.org/projects/doctrine-orm/en/2.11/reference/attributes-reference.html#jointable

---

It's quite confusing that ManyToOne supports nested attributes 🤔 ...ah, they were joined together by commad, it's actually a new attribute. Thanks god for ambiguous syntax :D

#[ManyToOne(targetEntity: Country:class)]
#[JoinColumn(name: "country_code", referencedColumnName: "country_code")]

Ref: https://www.doctrine-project.org/2022/01/11/orm-2.11.html

[javaDeveloperKid]

I can't find issue that lead me to creating this PR so can't find if it was resolved. However it still doesn't work in 0.13.10.

[TomasVotruba]

I think this will be solved now by #2781 🙂

Please rebase on dev-main, so we can see if it works propperly

[TomasVotruba]

I see... it needed move to the NestedAnnotationToAttributeRector and test only the nested items.
It moved it for you, to save you the hustle: #2785

[TomasVotruba]

It passes the CI ✔️ #2785

This fixture is already in there, so I close both PR to avoid duplications.