Add [file] + [rule] debug info on --debug + fix literal number downgrade type change to string #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
May 12, 2022
TomasVotruba
changed the title
TomasVotruba
commented
May 12, 2022
Comment on lines
110
to
118
| // we have to hack around tokens to get original value, see https://github.com/nikic/PHP-Parser/pull/832 | ||
| $oldTokens = $this->file->getOldTokens(); | ||
| $tokenValue = $oldTokens[$node->getStartTokenPos()][1] ?? null; | ||
|
|
||
| if ($tokenValue === null) { | ||
| return true; | ||
| } | ||
|
|
||
| return true; | ||
| return ! str_contains($tokenValue, '_'); |
There was a problem hiding this comment.
Hopefully we can get rid of this global token access after raw value is supported nativelly in both LNumber and DNumber:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/symplify/symplify/runs/6405930856?check_suite_focus=true
As there are dozens of rule that can be applied on a file, the combination of both is always crutial for debugging.
Before we had only all files or all rules at the same time, making it hard to find the duo.
Now Rector will print both right next to each other so it's easier to find even in big logs:
Ref #2292 (comment)